feat(create-fabrice-ai): downloading latest release #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
reviewed
Dec 13, 2024
grabbou
reviewed
Dec 13, 2024
grabbou
reviewed
Dec 13, 2024
grabbou
changed the title
create-fabrice-ai: downloading latest release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we downloaded the
mainsnapshot. It was fine. However, it didn't work well when the currentmainsource code was incompatible with the releasednpmmodules. This situation happened with the recent #105. Now, we're getting the latest official release and taking the examples out of it.Because the tarball starts with a directory of an unknown name (in fact, it's the
org-repo-lastcommitidkind of) - we're about to extract the full release and not only the example folder (as it was before) because the leading directory name is unknown.